[messagingframework] Update to upstream using DBus. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcaliste
force-pushed
the
dbus
branch
3 times, most recently
from
9b48d36
to
09a2116
Compare
|
Looks like this is missing the changes for the .spec file, especially related to the adjusted patch file set. The submodule is indeed problematic here, but I can separately reset it to your PR on upstream. |
|
Smoke test with this seems good so far. |
|
I've updated the spec files with respect to the patch listing. |
|
Adjusted with the right upstream sha. |
pvuorela
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure the submodule sha is pointing to something accessible, it corresponds to the code pushed to gerrit, currently under review. I'll update it when it will be accepted in gerrit.
@pvuorela, to test it on device, it requires to adjust some patches. So here they come.