[minui] Fix false positive gr_init() return value. JB#59813 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least drm backend can have situation where gr_init() gets non-null gr_draw buffer from backend init - which then turns to null due to failure within gr_flip(). As the latter is not checked, gr_init() can return success and application then crashes later on when null gr_draw gets dereferenced. Check that gr_draw remains non-null after initial gr_flip() calls. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
rainemak
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least drm backend can have situation where gr_init() gets non-null gr_draw buffer from backend init - which then turns to null due to failure within gr_flip(). As the latter is not checked, gr_init() can return success and application then crashes later on when null gr_draw gets dereferenced.
Check that gr_draw remains non-null after initial gr_flip() calls.
Signed-off-by: Simo Piiroinen simo.piiroinen@jolla.com