Separate private headers #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sqliteformat comments also adjusted to avoid any doxygen type of document generation.
pvuorela
force-pushed
the
separate_private_headers
branch
from
a5ceb93
to
a2c4e3c
Compare
dcaliste
reviewed
May 23, 2023
| Sqlite format implementation. | ||
|
|
||
| This class implements the Sqlite format. It provides methods for | ||
| loading/saving/converting Sqlite format data into the internal | ||
| representation as Calendar and Incidences. | ||
| */ | ||
| // exported just for unit test. Would be better to avoid. |
There was a problem hiding this comment.
Actually, it can be dropped with #60 I think. I'll amend it in that direction.
dcaliste
approved these changes
May 23, 2023
Tomin1
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed obsolete config-mkcal.h and avoiding installation of the more private headers. And avoid docs for private sqliteformat.h too.
@Tomin1 @dcaliste