Various minor changes to clean and allow multi-notebooks for incidence sharing the same UIDs #63
Conversation
Like for incidences, don't set milliseconds since the database is only saving up to second precision. Also ensure that invalid date times for notebook modification, creation and sync dates are restored as invalid date time and not as 1970-01-01T00:00.
Also don't specifically hide classes that need to be, since the code is compiled with -fvisibility=hidden.
…#60800 Don't base the alarm clearing on UID only, allowing later to get incidences with the same UID in different notebooks.
…s to JB#60800 Ensure that selecting a specific incidence from the components table is also using the notebook UID. This will allow to hav incidences sharing the same UID in different notebooks.
|
Hm, with this I seem to be having 3 failures on tst_storage. |
|
I've just recompiled this branch, copied the libmkcal-qt5.so.0.7.19 and the three test files to my device. I ran them with I ran the There are three warnings, two of them being valid (testing cases emitting a warning). The third one, I can remove if you want. I forgot to add the notebook to the newly changed |
|
Duh, I did some timezone test earlier and forgot the device to Pago Pago. Switching back to Helsinki made the tests pass. However, comparing the Pago Pago case, on current master it has two failures while this also fails on: |
|
No wait, the 2271 fail is there even on Helsinki and Paris. Hm. |
|
What I think is happening is that earlier the deleted instances were returned as the main event first, the unit test assumes that but now there are no more guarantees on what's the order of returned events. |
Very good catch. It's due to the last commit of the PR, so I amended it not to assume a specific order in the test. |
instanceIdentifier() can be used as a unique key to identify an incidence. Use it instead of UID to keep track of calendar changes.
@pvuorela, this is a spin off from #60 with the first commits before introducing the separation between DB support and calendar association.