Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlsdb: Update Mozilla Location DB offline data to 2022-03-22 #5

Merged
merged 1 commit into from Mar 24, 2022

Conversation

abranson
Copy link
Member

@abranson abranson commented Mar 22, 2022

[mlsdb] Update Mozilla Location DB offline data to 2022-03-22. JB#57070

Copy link
Contributor

@sledges sledges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please match the commit subject format that's used in this repo, "[foo] bar. b#z".
I would also recommend changing bug#ref to 57070, so it's easier to keep track internally.

@abranson
Copy link
Member Author

Done. Sorry, force of habit from other projects. We've been including that as the second line these days.

Copy link
Contributor

@sledges sledges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a good practice to check commit history, so whenever we contrib, we match upstreams too:)
Bug#ref is still not the final one, my bad as I edited github comment which doesn't send emails.

Using MLS-full-cell-export-2022-03-22T000000.csv
@abranson
Copy link
Member Author

Can anyone figure out why these new db files are dramatically smaller than the originals?

@sledges
Copy link
Contributor

sledges commented Mar 24, 2022

Looks like the whole DB's shrunk:

837.6M Feb 18  2021 MLS-full-cell-export-2021-02-18T000000.csv
365M   Mar 24 07:19 MLS-full-cell-export-2022-03-22T000000.csv

Seemingly less cell towers are now [known about?] in any given area that I tried, e.g.:

grep LTE,246,3 MLS-full-cell-export-2021-02-18T000000.csv | wc -l
3172
grep LTE,246,3 MLS-full-cell-export-2022-03-22T000000.csv | wc -l
1190

MLS downloads say:

The full cell export is limited to those cell networks whose position has been confirmed in the last 12 months.

Blame it on lockdowns = less movement of people? Following that should recover in the future. On the same page you can see tens of kB of compressed data already increasing daily.

@abranson
Copy link
Member Author

We were missing the previously used export to compare. Thanks, looks like everything's working properly with a smaller source dataset then.

@sledges
Copy link
Contributor

sledges commented Mar 24, 2022

That might cause ~3 times less quick assisted fix if coverage is 3 times more sparse:)

@abranson
Copy link
Member Author

Could also have been affected by the dropping of the Mozilla Stumbler data gathering app a year ago:

https://discourse.mozilla.org/t/retiring-mozilla-stumbler/75206

@abranson abranson merged commit 75c025a into master Mar 24, 2022
@abranson abranson deleted the updatedb branch March 24, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants