Jb53415 change data format #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abranson
approved these changes
Jan 9, 2023
LaakkonenJussi
approved these changes
Jan 9, 2023
updateData.sh
Outdated
| popd | ||
| done | ||
| TOOL=$1 | ||
| FILE=$2 |
updateData.sh
Outdated
| @@ -1,22 +1,126 @@ | |||
| #/bin/sh | |||
| #/bin/bash | |||
| Australia="au" | ||
| India="in" | ||
|
|
||
| cat <<EOF > $SPEC |
There was a problem hiding this comment.
Not that $SPEC contains spaces but maybe quotes?
updateData.sh
Outdated
| pushd $region | ||
| $TOOL -r $region $FILE | ||
| popd | ||
| mkdir -p $region |
There was a problem hiding this comment.
mkdir -p $region
^-----^ SC2086: Double quote to prevent globbing and word splitting.
Did you mean:
mkdir -p "$region"
| $TOOL -r $region $FILE | ||
| popd | ||
| mkdir -p $region | ||
| echo "%files $region" | tr [:upper:] [:lower:] | tr '_' '-' >> $SPEC |
There was a problem hiding this comment.
echo "%files $region" | tr [:upper:] [:lower:] | tr '_' '-' >> $SPEC
^-------^ SC2060: Quote parameters to tr to prevent glob expansion.
^-------^ SC2060: Quote parameters to tr to prevent glob expansion.
updateData.sh
Outdated
| mkdir -p $region | ||
| echo "%files $region" | tr [:upper:] [:lower:] | tr '_' '-' >> $SPEC | ||
| echo "%defattr(-,root,root,-)" >> $SPEC | ||
| pushd $region |
There was a problem hiding this comment.
pushd $region
^-----------^ SC2164: Use 'pushd ... || exit' or 'pushd ... || return' in case pushd fails.
^-----^ SC2086: Double quote to prevent globbing and word splitting.
updateData.sh
Outdated
| # ${!var} is bash indirect referencing, i.e. accessing whatever is in the | ||
| # variable with the name that is stored in $var. | ||
| for country in ${!region} ; do | ||
| mccs=`../$TOOL ../$FILE $country | sed 's/.*://'` |
There was a problem hiding this comment.
mccs=`../$TOOL ../$FILE $country | sed 's/.*://'`
^-- SC2006: Use $(...) notation instead of legacy backticked `...`.
^---^ SC2086: Double quote to prevent globbing and word splitting.
^---^ SC2086: Double quote to prevent globbing and word splitting.
^------^ SC2086: Double quote to prevent globbing and word splitting.
| echo "%{_datadir}/geoclue-provider-mlsdb/data/${mcc}.dat" >> ../$SPEC | ||
| done | ||
| done | ||
| popd |
There was a problem hiding this comment.
popd
^--^ SC2164: Use 'popd ... || exit' or 'popd ... || return' in case popd fails.
Did you mean:
popd || exit
|
Please squash the commits |
dsuni
force-pushed
the
jb53415_change_data_format
branch
3 times, most recently
from
8abc75d
to
c148198
Compare
This matches the changes made in geoclue-providers-mlsdb. It also updates the data used to MLS-full-cell-export-2023-01-09T000000.csv
pvuorela
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.