Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mobile Vikings MNC code was not correct so link fot more info on … #21

Merged
merged 3 commits into from Feb 20, 2024

Conversation

ruditimmermans
Copy link
Contributor

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on forum and the mobile vikings website there seems to be a bit conflicting information, but none having the current mnc 20. If this gets it working for you, I'm assumign it's for the better.

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better now, but could you still rebase and squash the commits to avoid intermediate steps in the git history. I.e. git rebase -i origin/master and mark the latter commit with 's'.

@ruditimmermans
Copy link
Contributor Author

Looks better now, but could you still rebase and squash the commits to avoid intermediate steps in the git history. I.e. git rebase -i origin/master and mark the latter commit with 's'.

I'm sorry i work directly online via the Github website and i never used Git itself on Windows so this is my first time i have dont something like this sorry....

@pvuorela
Copy link
Contributor

I'm sorry i work directly online via the Github website and i never used Git itself on Windows so this is my first time i have dont something like this sorry....

Ah, interesting. But no worries, I can also do some squashing with the merging. Just commonly better if PR author handles that.

@pvuorela pvuorela merged commit 4a16172 into sailfishos:master Feb 20, 2024
@ruditimmermans
Copy link
Contributor Author

I'm sorry i work directly online via the Github website and i never used Git itself on Windows so this is my first time i have dont something like this sorry....

Ah, interesting. But no worries, I can also do some squashing with the merging. Just commonly better if PR author handles that.

Ok i understand i will look on git how this works for into the future i do something myself, thanks for the helps!

@ruditimmermans
Copy link
Contributor Author

Hi Pekka,

I was into a talk with Jussi into a private message on the forum and we found out my mobile network would be crashing with Offono i send the offono logs back to Jussi but i dont hear anything more, would i need to send the logs to you also or someone elsse ?

Thanks!
Rudi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants