[nemo-qml-plugin-calendar] Add a displayLabel per occurrence. #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a displayLabel per occurrence allows to adjust it for
recurring events like birthdays. So the label can change
with the occurrence and display the age for instance.
@chriadam and @pvuorela , after thinking a lot how to implement an age display for the birthdays, I concluded that it must be done at the occurrence level. It's the object that is changing for a given event (like a day of birth) at every iteration. By overloading the displayLabel (or the description) of the occurrences, one can implement a display of the age at the given day.
Now, there are still some ugly bits :
Of course, there are one or two places in the Jolla calendar application where there should be a
s/event ? event.displayLabel : ""/occurrence ? occurrence.displayLabel : ""/. The PR is not done at the moment. I would like to discuss the approach here to the problem first.