Update plugin #42
Merged
Update plugin #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ed Beroset <beroset@ieee.org>
dcaliste
suggested changes
Jan 24, 2023
The code in CalendarWorker::loadData() was iterating over copies of pointers, rather than the pointers in the container. This fixes that bug. Signed-off-by: Ed Beroset <beroset@ieee.org>
The previous code had this line for iteration:
for (const KCalendarCore::Incidence::Ptr &incidence : mEventList) {
The gcc compiler rightly complains that the loop variable 'incidence' of type 'const Ptr&'
{aka 'const QSharedPointer<KCalendarCore::Incidence>&'} binds to a temporary constructed from
type 'const QSharedPointer<KCalendarCore::Event>'
This version fixes that problem:
for (const KCalendarCore::Event::Ptr& incidence : mEventList) {
Signed-off-by: Ed Beroset <beroset@ieee.org>
beroset
force-pushed
the
update-plugin
branch
from
c7576fa
to
9039291
Compare
dcaliste
suggested changes
Jan 24, 2023
beroset
force-pushed
the
update-plugin
branch
from
9039291
to
2b2d7ea
Compare
dcaliste
approved these changes
Jan 24, 2023
beroset
force-pushed
the
update-plugin
branch
from
2b2d7ea
to
5ce5036
Compare
|
Thanks for the update, looks good to me. I'll run the tests tomorrow to be sure. |
dcaliste
suggested changes
Jan 24, 2023
The QDateTime(const QDate&) constructor is deprecated, so this uses QDateTime(QDate.startOfDay()) or QDateTime(QDate.endOfDay()) as appropriate. This also simplified one place in calendarworker.cpp in CalendarWorker::eventOccurrences(). In that, an elaborate dance to get the last second of the second date was replaced by simply using QDate.endOfDay(). In all cases this is done with a QT_VERSION_CHECK(5, 14, 0) so compiling with earlier versions of QT will still work. Signed-off-by: Ed Beroset <beroset@ieee.org>
beroset
force-pushed
the
update-plugin
branch
from
5ce5036
to
64e130b
Compare
|
Running the tests myself they pass fine. The Qt <5.14 changes don't either seem too big. Would be fine for me already, but waiting a moment if @dcaliste still had some comments. |
|
Thanks @pvuorela for testing also. I guess the failing ones come from my setup (I'll investigate later, since it's not related to the changes here). It's all good to me. |
pvuorela
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In working with this plugin on AsteroidOS, I found that I had to make some changes to allow it to compile and run cleanly with gcc 11.