[nemo-qml-plugin-calendar] Add a thisAndFuture attribute to EventModi… #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a quick glance looks nice and simple, but maybe I'll not hit the merge button immediately as there's nothing to use this yet. |
|
Indeed, I still need to polish the UI part using it ; ) |
…fication objects. This attribute is used for EventModification objects created to modify an occurrence. It is saved to the database and allow to apply modifications to a recurring event for all future occurrences of a given date.
…ture cases In KCalendarCore::OccurrenceIterator, the exceptions are find matching the recurrenceId with the generated occurence start time from timesInInterval() called on the parent, whatever the value of the current this and future exception. Moreover, ExtendedCalendar::dissociateSingleOccurrence() is checking that recurrenceId is a valid recurring time date for the parent and not the current this and future exception. Which is consistent with KCalendarCore so far. Thus, when calling the dissociation on an occurrence coming from a this and future exception, apply a shift due to the exception when creating the recurrenceId.
dcaliste
force-pushed
the
thisAndFuture
branch
from
34f4967
to
375bdd3
Compare
…this and future occurrences. The event passed to deleteEvent() in case of an occurrence later than an this and future exception is the exception. Add a specific case to ensure that the propoer EXDATE is added to the parent.
dcaliste
force-pushed
the
thisAndFuture
branch
from
67a9a56
to
81ee984
Compare
|
I've added two commits on top adding support to delete occurrences later than a this and future exception or to modify them. It requires to add a shift to get the proper recurrenceId, suitable for the parent, from the startTime of the occurrence, due to possible change in dtStart with the this and future exception used as a base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fication objects.
This attribute is used for EventModification objects created to modify an occurrence. It is saved to the database and allow to apply modifications to a recurring event for all future occurrences of a given date.
@pvuorela, it requires sailfishos/mkcal#46 to be built.