[nemo-qml-plugin-calendar] Avoid creating a manager on delete. #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainemak
reviewed
May 25, 2023
rainemak
requested changes
May 25, 2023
pvuorela
reviewed
May 30, 2023
rainemak
approved these changes
May 30, 2023
If the model and the manager are both owned by the QApplication, they may be deleted in a random order on application quit. We should then avoid to recreate a manager if this one has been already deleted. This situation is happening in the tests for instance.
pvuorela
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the model and the manager are both owned by
the QApplication, they may be deleted in a
random order on application quit. We should
then avoid to recreate a manager if this one
has been already deleted.
This situation is happening in the tests for
instance.
@pvuorela , I encountered this problem in the searchmodel test for instance. It created random segfault or a warning about QEventLoop lacking of a QApplication after the test complete.