[nemo-qmlplugin-calendar] Don't expect a calendar reset on a notebook… #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… change. mKCal is not emitting a storageModified signal on in-process notebook changes. For a visibility change, the excludedNotebookChanged signal is already asking for a reset. Only missing case was when changing the default notebook. Color changes are also handled by the existing notebooksChanged slot in the manager.
pvuorela
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… change.
mKCal is not emitting a storageModified signal
on in-process notebook changes. For a visibility
change, the excludedNotebookChanged signal is already asking for a reset. Only missing case was when
changing the default notebook. Color changes are
also handled by the existing notebooksChanged
slot in the manager.
As a follow-up of sailfishos/mkcal#64. Interestingly enough, there is almost no change to be done to handle the modification in mKCal. I've added a test for the visibility change, to ensure that it's still working.