Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugins.qmltypes. JB#59899 #3

Merged
merged 1 commit into from Jan 25, 2023
Merged

Add plugins.qmltypes. JB#59899 #3

merged 1 commit into from Jan 25, 2023

Conversation

martyone
Copy link
Member

No description provided.

@pvuorela
Copy link
Contributor

The battery and other providers should be here an implementation detail which shouldn't be leaking outside. The public API is ContextProperty.qml and based on its "key" property it internally loads some provider to output the "value" property.

Being just that, do we need any qmltypes here?

@martyone
Copy link
Member Author

The effort has been to provide coding assistance for all APIs, with no distinction between internal and public APIs. Platform developers are not 2nd class citizen :)

@pvuorela
Copy link
Contributor

The effort has been to provide coding assistance for all APIs, with no distinction between internal and public APIs. Platform developers are not 2nd class citizen :)

Not sure if talking about the same thing. The provider thing is only internal to the module so would be helpful if somebody developed providers inside this repository. New providers I will not accept here, this is here mostly for backwards compatibility.

@martyone
Copy link
Member Author

Yes, understood, only helpful to someone working on src/providers/Battery.qml. Even that you find it utterly useless, the fact that I do not make an exception actually saves me a maintenance effort.

@pvuorela
Copy link
Contributor

Ok. I'll approve. Shouldn't hurt too much even if it didn't provide much.

@martyone martyone merged commit 1f1d03d into master Jan 25, 2023
@martyone martyone deleted the jb59899 branch January 25, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants