Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diskusage] Fix apkd size calls for AAS. JB#58028 #4

Merged
merged 2 commits into from May 11, 2022
Merged

Conversation

abranson
Copy link
Member

@abranson abranson commented May 5, 2022

getAndroidAppDataUsage has been reimplemented to query app and data sizes
from within the container, so both of those come from apkd for AAS.

The old android home distinction is no longer relevant after support for the Jolla1 was removed, so that's dropped.

Copy link
Member

@Tomin1 Tomin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Some style related comments and wondering a little about that one warning message. I would approve with those style fixes. 👍

src/plugin/diskusage_impl.cpp Outdated Show resolved Hide resolved
src/plugin/diskusage_impl.cpp Outdated Show resolved Hide resolved
src/plugin/diskusage_impl.cpp Outdated Show resolved Hide resolved
src/plugin/diskusage.cpp Outdated Show resolved Hide resolved
src/plugin/diskusage_impl.cpp Outdated Show resolved Hide resolved
src/plugin/diskusage.cpp Outdated Show resolved Hide resolved
getAndroidAppDataUsage has been reimplemented to query app and data sizes
from within the container, so both of those come from apkd for AAS.

Add more debugging to DiskUsage, with a logging category.
@abranson abranson merged commit 8ce5809 into master May 11, 2022
@abranson abranson deleted the jb58076 branch May 11, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants