[filemanager] replace euidaccess() with opendir() #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainemak
reviewed
Jan 26, 2023
NotKit
force-pushed
the
jb59856
branch
2 times, most recently
from
3778e8f
to
a6e568c
Compare
NotKit
changed the title
|
Tested on Xperia 10 II and works fine. |
rainemak
reviewed
Jan 26, 2023
rainemak
approved these changes
Jan 26, 2023
…59856 euidaccess implementation in glibc directly compares effective uid/gid to Unix permissions of file and does not take Posix ACLs into account. Since we only need this check to display a meaningful error message, call opendir instead and check if it succeeds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
euidaccess implementation in glibc directly compares effective uid/gid to Unix permissions of file and does not take Posix ACLs into account.
Since we only need this check to display a meaningful error message, call opendir instead and check if it succeeds.