fix some deprecated types to be able compile with Qt6 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QList<QString> to QSet<QString> is now done via constructor instead of .toSet() QRegExp is replaced by QRegularExpression
pvuorela
reviewed
May 30, 2023
| @@ -99,13 +99,13 @@ void SortFilterModel::setFilterRegExp(const QString &exp) | |||
| if (exp == filterRegExp()) { | |||
| return; | |||
| } | |||
| QSortFilterProxyModel::setFilterRegExp(QRegExp(exp, Qt::CaseInsensitive)); | |||
| QSortFilterProxyModel::setFilterRegularExpression(QRegularExpression(exp, QRegularExpression::CaseInsensitiveOption)); | |||
There was a problem hiding this comment.
Doesn't compile on qt 5.6. Seems to be added in 5.12. -> should have some #iffing to support also older qt
|
I see, I have tried only with Qt 5.15 and Qt 6. I will fix it. |
pvuorela
approved these changes
Jun 6, 2023
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QList to QSet is now done via constructor instead of .toSet() QRegExp is replaced by QRegularExpression