Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Qt6 #5

Merged
merged 1 commit into from Nov 27, 2023
Merged

Fix build with Qt6 #5

merged 1 commit into from Nov 27, 2023

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Aug 25, 2023

I need to check what parts needs conditional compiling for older qt.

Copy link

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmlich jmlich force-pushed the master branch 2 times, most recently from 12ba748 to 9689976 Compare August 31, 2023 10:24
Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cpp changes are missing Qt version checks. Currently this will not build with Qt5.6. Changes needed for searchmodel.cpp & filtermodel.cpp

@jmlich
Copy link
Contributor Author

jmlich commented Aug 31, 2023

I am sorry, I was so happy that it finally with Qt 6 that I forgot to make sure that it works also with previous version. I will fix that soon.

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds with Qt 5.6. Seems all good.

@pvuorela pvuorela merged commit bc5d853 into sailfishos:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants