Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build against Qt6. #8

Merged
merged 1 commit into from Jun 6, 2023
Merged

Build against Qt6. #8

merged 1 commit into from Jun 6, 2023

Conversation

mkosola
Copy link
Contributor

@mkosola mkosola commented May 30, 2023

No description provided.

@mkosola
Copy link
Contributor Author

mkosola commented May 30, 2023

Ah, need to add ifdef to build properly

Tomin1
Tomin1 requested changes May 30, 2023
View reviewed changes
Copy link
Member

@Tomin1 Tomin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs ifdefs.

src/notification.cpp Show resolved Hide resolved
src/notification.cpp Show resolved Hide resolved
Tomin1
Tomin1 reviewed May 30, 2023
View reviewed changes
Copy link
Member

@Tomin1 Tomin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better. I'm wondering about the version numbers though since those were introduced already before 6.0.

src/notification.cpp Outdated Show resolved Hide resolved
src/notification.cpp Outdated Show resolved Hide resolved
@mkosola
[nemo-notifications] Build against Qt6. JB#60822
4456ce2 
Signed-off-by: Matti Kosola <matti.kosola@jolla.com>
@mkosola mkosola requested a review from pvuorela June 6, 2023 12:51
@mkosola mkosola merged commit b07d655 into master Jun 6, 2023
@mkosola mkosola deleted the jb60822 branch June 6, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomin1 Tomin1 Tomin1 approved these changes

@pvuorela pvuorela pvuorela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mkosola @Tomin1 @pvuorela