[notifications] Support passing action type info. JB#55557 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implicitly use "input" if there's input info set for the action. The type is easier to handle on the notification manager side and the existing way to pass the "input" map verbatim from app to d-bus feels suspicious. Think we should revisit the whole action text parameter details, but at the moment it's not too much exposed to the apps nor supported so we can get back into that later.
Tomin1
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly use "input" if there's input info set for the action. The type is easier to handle on the notification manager side and the existing way to pass the "input" map verbatim from app to d-bus feels suspicious.
Think we should revisit the whole action text parameter details, but at the moment it's not too much exposed to the apps nor supported so we can get back into that later.