[battery] Allow to control charging hysteresis. JB#58372 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyone
force-pushed
the
jb58372
branch
2 times, most recently
from
bfb3c75
to
47a3e7e
Compare
|
Refactored to use MCE's settings API. The diff to look at is ff4f4e3..47a3e7e. |
|
Refactored the write side too, fixed D-Bus signal handling. |
|
Updated after dropping change to enum ordering on mce side. |
rainemak
reviewed
Aug 26, 2022
Unlike MCE, here we use the natural ordering for the ChargingMode enum, using first item for the default value (EnableCharging). Signed-off-by: Martin Kampas <martin.kampas@jolla.com>
rainemak
approved these changes
Sep 2, 2022
spiiroin
reviewed
Oct 3, 2022
| @@ -59,6 +73,18 @@ BatteryStatusPrivate::BatteryStatusPrivate(BatteryStatus *batteryInfo) | |||
| registerSignals(); | |||
|
|
|||
| // read initial values | |||
| NemoDBus::Response *chargingMode = m_mceInterface.call(MCE_CONFIG_GET, | |||
There was a problem hiding this comment.
nit: we have had problems with exceeding max number of pending method calls during startup of some processes, and this 3 x { MCE_CONFIG_GET } could be handled via 1 x { MCE_CONFIG_GET_ALL }. For ref see displaysettings.cpp
...
| switch (mode) { | ||
| default: | ||
| case BatteryStatus::EnableCharging: | ||
| return MceChargingModeEnable; |
There was a problem hiding this comment.
consistency nit: return from default: here vs. return from outside switch in the above function. Both ways are just fine, but now there are two very similar methods that look different. Feel free to ignore ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.