[battery] Allow to control charging hysteresis #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike MCE, here we use the natural ordering for the ChargingMode enum, using first item for the default value (EnableCharging). Signed-off-by: Martin Kampas <martin.kampas@jolla.com>
martyone
reviewed
Oct 12, 2022
spiiroin
force-pushed
the
jb58372_charging_settings
branch
from
d7335c0
to
fe8aa45
Compare
|
Review commits squashed |
martyone
approved these changes
Oct 18, 2022
Required constants are defined in mce-dev >= 1.31.0 The D-Bus methods and signals are available in mce >= 1.112.0 Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb58372_charging_settings
branch
from
0acda5c
to
0f36a74
Compare
|
Review commits squashed |
pvuorela
approved these changes
Oct 20, 2022
spiiroin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.