Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vpn] Account for Association state. JB#59447 #32

Merged
merged 2 commits into from Dec 19, 2022
Merged

[vpn] Account for Association state. JB#59447 #32

merged 2 commits into from Dec 19, 2022

Conversation

LaakkonenJussi
Copy link
Contributor

Account for Association state in top menu.

@LaakkonenJussi
Copy link
Contributor Author

Related to changes in sailfishos/connman#34 & sailfishos/libconnman-qt#12

spiiroin
spiiroin approved these changes Dec 9, 2022
View reviewed changes
src/settingsvpnmodel.cpp Show resolved Hide resolved
@LaakkonenJussi
[vpn] Account for Association state. JB#59447
a8aea68 
Account for Association state in top menu. Reformat the numericValue()
function to use switch.
llewelld
llewelld approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@llewelld llewelld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a minor thing, and not essential, but you could bump the connman-qt requirement up to whichever version ends up including the enum, to make it easier for others to build.

Thaodan
Thaodan approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except the comment I added.

@LaakkonenJussi
Copy link
Contributor Author

It's a minor thing, and not essential, but you could bump the connman-qt requirement up to whichever version ends up including the enum, to make it easier for others to build.

Yep. I was going to do that when everything is LGTM'd. That is because in OBS it is a bit of a hazzle to get all of these built if I bumb the dependencies now.

@LaakkonenJussi
Version 0.10.1
893150f 
Bump also libconnman-qt requirement to include the version that supports
association state for VPNs.
@LaakkonenJussi LaakkonenJussi merged commit aec4b1d into sailfishos:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llewelld llewelld llewelld approved these changes

@Thaodan Thaodan Thaodan approved these changes

@spiiroin spiiroin spiiroin approved these changes

@rainemak rainemak Awaiting requested review from rainemak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@LaakkonenJussi @llewelld @Thaodan @spiiroin