Add support for data-ciphers and data-ciphers-fallback to OpenVPN

[LaakkonenJussi]

No description provided.

[LaakkonenJussi]

Need to check the provisioning file format for this and test it.

[LaakkonenJussi]

The options are:

data-ciphers AES-128-CBC:AES-192-CBC:AES-192-CFB:AES-192-OFB:AES-256-CBC:AES-256-CFB:AES-256-OFB
data-ciphers-fallback AES-128-CBC

So maybe we should support the fallback cipher as well. And to ensure that the ciphers line gets parsed.

[LaakkonenJussi]

@mlehtima Since the whole data-ciphers arg is one big string we do not really need to parse it, just take it as a whole. We do not do much verification here either so no use starting to do it now. If we do, we make a new task to add verification for all.

[Thaodan]

@mlehtima Since the whole data-ciphers arg is one big string we do not really need to parse it, just take it as a whole. We do not do much verification here either so no use starting to do it now. If we do, we make a new task to add verification for all.

I wonder if makes sense to have all the options matched to each vpn type in a map which property is which option for connman.

We can use something like std::map<QString, QString> and then use std::map::find or std::map::contains (C++20).

[Thaodan]

Approved, see suggestion in comment.

[LaakkonenJussi]

I wonder if makes sense to have all the options matched to each vpn type in a map which property is which option for connman.

We can use something like std::map<QString, QString> and then use std::map::find or std::map::contains (C++20).

This could for sure use some improvement. Updating this does indeed seem a bit of a mess but we'll create another task for that.