[nemo-qml-plugin-time] Stabilize the unit test. JB#57887 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comparing exact seconds between WallClock and QDateTime::currentDateTime() is just waiting for failures as occasionally the second will change on wrong place. Giving it now some leeway. Also we don't need to test javascript datetime field getter api here.
Tomin1
approved these changes
Apr 1, 2022
spiiroin
approved these changes
Apr 1, 2022
| QVERIFY(time.isValid()); | ||
| int timeSecs = time.toMSecsSinceEpoch() / 1000; | ||
| // giving some leeway | ||
| QVERIFY(currentSecs == timeSecs || currentSecs == timeSecs + 1); |
There was a problem hiding this comment.
I see no reason why this would not work, but ...
There is toSecsSinceEpoch() method that could be used instead of dividing millsecs by 1000.
Or, depending on is jitter expected only in one or both directions, one could perhaps use some form of QVERIFY(abs(deltaInMs) <= 1000) type thing.
There was a problem hiding this comment.
"This function was introduced in Qt 5.8." 🤔
But I like the idea of using abs() there.
There was a problem hiding this comment.
One slight problem with abs(), even if small, is that it wouldn't guarantee the ordering of the timestamps.
There was a problem hiding this comment.
Since this is approved, I'll just merge :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comparing exact seconds between WallClock and QDateTime::currentDateTime()
is just waiting for failures as occasionally the second will change
on wrong place. Giving it now some leeway.
Also we don't need to test javascript datetime field getter api here.
@spiiroin @Tomin1