fix null pointer dereference #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QML VideoOutput documentation says that "...you can provide a QObject based class with a writable `videoSurface` property..." (as a source). QDeclarativeVideoOutput then tries to initialize video backend with nullptr service. It leads to null pointer dereference and crash in NemoVideoTextureBackend::init. Crash stacktrace: #0 0x0000007280487ed0 in NemoVideoBackend::NemoVideoTextureBackend::init (this=0x60b4fb10d0, service=0x0) at videotexturebackend.cpp:614 sailfishos#1 0x0000007284a26ea4 in QDeclarativeVideoOutput::createBackend (this=this@entry=0x60b4f84c10, service=service@entry=0x0) at /usr/include/qt5/QtCore/qscopedpointer.h:127 sailfishos#2 0x0000007284a27c14 in QDeclarativeVideoOutput::setSource (this=0x60b4f84c10, source=0x60b527f520) at qdeclarativevideooutput.cpp:206 #3 0x0000007284a2f078 in QDeclarativeVideoOutput::qt_metacall (this=0x60b4f84c10, _c=QMetaObject::WriteProperty, _id=0, _a=0x7ff48f04c0) at .moc/moc_qdeclarativevideooutput_p.cpp:343 #4 0x000000728e71bd74 in QQmlPropertyPrivate::write (object=object@entry=0x60b4f84c10, property=..., value=..., context=0x60b4f55e20, flags=flags@entry=...) at qml/qqmlproperty.cpp:1252
|
For integration purposes created JB#58252 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QML VideoOutput documentation says that "...you can provide a QObject
based class with a writable
videoSurfaceproperty..." (as a source).QDeclarativeVideoOutput then tries to initialize video backend with
nullptr service. It leads to null pointer dereference and crash
in NemoVideoTextureBackend::init.
Crash stacktrace: