Fix raciness on MCE plugin. JB#61050 #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix typo, remove unused variable, remove couple hard tabs in the middle of indentation by spaces.
mlehtima
requested changes
Nov 30, 2023
Scenario: - have event in play state, optionally wait some time before continuing - stop event - restart event quickly after the previous - mce signal for stop arrives, previous restart is still pending on mce - code calls n_sink_interface_complete, which seems to trigger yet another stop. Thus now tracking for active event when mce reports them playing and ignoring the deactivation signal that comes too soon. Stop also tracks what's expecting to be active.
pvuorela
force-pushed
the
mce_robustness
branch
from
5e69c65
to
400fc45
Compare
mlehtima
approved these changes
Nov 30, 2023
spiiroin
approved these changes
Dec 1, 2023
| { | ||
| (void) core; | ||
| (void) msg; | ||
| gchar *pattern = (gchar*) userdata; |
There was a problem hiding this comment.
nit: As this is C: superfluous void pointer cast. Then again, the already existing code is littered with these... nevermind
jusa
requested changes
Dec 1, 2023
jusa
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario:
Thus now tracking for active event when mce reports them playing and ignoring the deactivation signal that comes too soon. Stop also tracks what's expecting to be active.
Also another commit for a couple minor cleanups.