New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[poppler] Update to 22.09.0. #2
Conversation
Yeah, you should first get the jpeg_mem_src change in. And then I think you should change the BuildRequire to libjpeg-turbo-devel >= 2.1.0+git2, as this change depends on a change introduced there. It's unfortunate that pkgconfig versioning only goes to the "2.1.0" level. The "update in the sdk" part is easy, you just need to use shared output directory for both projects. |
The patch seems to have accumulated some offset with the upstream. Would be nice if you recreated that. Apply to git and then export back to file. git format-patch with --no-numbered --zero-commit |
The patch seems to have accumulated some offset with the upstream. Would be
nice if you recreated that. Apply to git and then export back to file. git
reformat-patch with --no-numbered --zero-commit
Please use: format-patch --no-numbered --zero-commit --no-signature --full-
index
|
73f08a1
to
acfac36
Compare
Re-exported patch, added another to not build demos since they now use qt 5.7 stuff, and updated the version in spec. |
No never unless the dependency generator for your language isn't packaged. RPM will resolve any dependency. |
And of course there has been a new release, with a fix for a pretty nasty CVE (FORCEDENTRY-related). |
Just update this one, fine as long as the commit message matches the content. |
acfac36
to
44a4ec3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good.
WIP: depends on jpeg_mem_src, and i have yet to figure out how to update in the sdk.
Minor freshening up of the Qt compat patch.