[profiled] Config dir change from .profiled to .config/profiled JB#9225 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
requested changes
Jan 16, 2023
database.c
Outdated
| if (snprintf(path, sizeof(path), "%s/.config/profiled", getenv("HOME")) < 0) | ||
| { | ||
| log_err("Path %s/.config/profiled is too long. Max size %lu\n", getenv("HOME"), sizeof(path)); | ||
| snprintf(path, sizeof(path), "/tmp"); |
There was a problem hiding this comment.
This goes all wrong now...
Old code: protected against side effects of NULL $HOME and dontcare if $HOME is bonkers long (under assumption that it will be checked later on or something).
New code: removes NULL protection, adds incorrect "path too long" check (snprintf returns number of chars it would have written if there were space, negative values are something else) and superfluous parentheses for sizeof...
There was a problem hiding this comment.
Please don't hardcode $HOME/.config but use $XDG_CONFIG_HOME
Thaodan
requested changes
Jan 16, 2023
database.c
Outdated
| if (snprintf(path, sizeof(path), "%s/.config/profiled", getenv("HOME")) < 0) | ||
| { | ||
| log_err("Path %s/.config/profiled is too long. Max size %lu\n", getenv("HOME"), sizeof(path)); | ||
| snprintf(path, sizeof(path), "/tmp"); |
There was a problem hiding this comment.
Please don't hardcode $HOME/.config but use $XDG_CONFIG_HOME
pvuorela
reviewed
Jan 16, 2023
database.h
Outdated
| @@ -85,6 +85,8 @@ void database_reload(void); | |||
|
|
|||
| void database_set_restart_request_cb(void (*cb)(void)); | |||
|
|
|||
| void migrate_configs (const char *legacy, const char *current); | |||
There was a problem hiding this comment.
No need to expose in the header?
Thaodan
requested changes
Jan 16, 2023
database.c
Outdated
| { | ||
| static char path[256] = ""; | ||
|
|
||
| if( *path == 0 ) | ||
| { | ||
| snprintf(path, sizeof path, "%s/.profiled", getenv("HOME") ?: "/tmp"); | ||
| snprintf(path, sizeof(path), "%s/.profiled", getenv("HOME") ?: "/tmp"); |
spiiroin
requested changes
Jan 17, 2023
Thaodan
reviewed
Jan 18, 2023
dsuni
force-pushed
the
jb9225_fix_conf_dir
branch
from
712103c
to
add2334
Compare
spiiroin
requested changes
Jan 26, 2023
dsuni
force-pushed
the
jb9225_fix_conf_dir
branch
from
add2334
to
8878502
Compare
spiiroin
approved these changes
Jan 30, 2023
dsuni
force-pushed
the
jb9225_fix_conf_dir
branch
from
8878502
to
b8724e7
Compare
If the config files can not be found in the new location, it will attempt to move the files from the old location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a oneshot script that moves the old files to the new directory.