Use timestamps for byte code invalidation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thaodan
approved these changes
Aug 9, 2022
This restores some performance on imports by using mtime instead of checksum to tell if byte code files are still valid. The patch is from Fedora. Signed-off-by: Tomi Leppänen <tomi.leppanen@jolla.com>
Tomin1
force-pushed
the
jb57221_timestamps
branch
from
40cee1d
to
a6c6b93
Compare
|
Dropped the first commit because it was enabled globally. |
Tomin1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make builds more reproducible by telling rpmbuild to set SOURCE_DATE_EPOCH variable from timestamp in changelog.[EDIT: Done elsewhere.] However, building this can still generate different byte code in pyc files so that they don't match to previous build.Add a patch from Fedora to mitigate the effect on import performance.