Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with Qt6 #1

Merged
merged 1 commit into from Nov 27, 2023
Merged

Fix build with Qt6 #1

merged 1 commit into from Nov 27, 2023

Conversation

jmlich
Copy link
Contributor

@jmlich jmlich commented Aug 28, 2023

No description provided.

@jmlich jmlich mentioned this pull request Aug 28, 2023
52 tasks
Copy link
Contributor

@Thaodan Thaodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the commits match these docs:
https://docs.sailfishos.org/Tools/Sailfish_SDK/Building_packages/#changelog-generation

You can use the bug tag JB#61015.

Also this is about supporting Qt 6 rather than fixing it.

@rainemak
Copy link
Member

Please make the commits match these docs: https://docs.sailfishos.org/Tools/Sailfish_SDK/Building_packages/#changelog-generation

You can use the bug tag JB#61015.

Also this is about supporting Qt 6 rather than fixing it.

Guiding to use internal bug references is not really good idea as those are only visible for the internals. Just having "Fix build with Qt6" is perfectly fine. Current commit message is missing period after summary right before JB#61015 and it's missing component name as well. Due missing component name change log would not be generated. Simpler just to drop JB#61015.

The one who merges and tags should annotate a tag with correct change log syntax.

My apologies @jmlich that this goes back and forth.

Copy link
Contributor

@pvuorela pvuorela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all nice an simple here.

@pvuorela pvuorela merged commit 215c1b5 into sailfishos:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants