[sensorfw] Use setDataRate() for settings data rates. Fixes JB#60417 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiiroin
commented
Mar 22, 2023
mlehtima
approved these changes
Mar 27, 2023
Sensorfwd setInterval() method takes time in milliseconds -parameter which is reciprocal of requested data rate in Hertz. As the time value is an integer, this severely limits the available data rates especially in the high end to: 1000, 500, 333, 250, 200, ... Hz Switch to using setDataRate() which is available in sensorfwd >= 0.13.0. It is both conceptually better match with qt side sensor interfaces and more future proof as data rate is transferred over D-Bus as floating point value. Signed-off-by: Simo Piiroinen <simo.piiroinen@jolla.com>
spiiroin
force-pushed
the
jb60417_data_rates
branch
from
e8cb152
to
dd29402
Compare
pvuorela
reviewed
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sensorfwd setInterval() method takes time in milliseconds -parameter which is reciprocal of requested data rate in Hertz. As the time value is an integer, this severely limits the available data rates especially in the high end to: 1000, 500, 333, 250, 200, ... Hz
Switch to using setDataRate() which is available in sensorfwd >= 0.13.0. It is both conceptually better match with qt side sensor interfaces and more future proof as data rate is transferred over D-Bus as floating point value.