Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[qtwebkit] Strip debug symbols from the shared libraries. Fixes JB#57198 #1

Merged
merged 1 commit into from Mar 25, 2022
Merged

[qtwebkit] Strip debug symbols from the shared libraries. Fixes JB#57198 #1

merged 1 commit into from Mar 25, 2022

Conversation

llewelld
Copy link
Member

This reduces the binary size. Since QtWebKit is deprecated removing the
debug symbols should have minimal impact.

@llewelld
Copy link
Member Author

I'm not sure whether this is the correct/best way to do this. It produces sensible results though: the files reduce in size, file, which returned "not stripped" before, now returns "stripped"; QtWebKit continues to work on the device.

@Thaodan
Copy link

Thaodan commented Mar 23, 2022 •
edited

Is the -debuginfo subpackage generation not working here?

@llewelld
Copy link
Member Author

Ah, I see. Apparently not. I'll look into it further.

@llewelld llewelld marked this pull request as draft March 23, 2022 20:14
@llewelld llewelld force-pushed the jb57198 branch 2 times, most recently from 046e785 to bbf1ed1 Compare March 25, 2022 07:08
@llewelld
Copy link
Member Author

I've updated the PR. It now keeps the debug symbols (-g1 compressed to reduce space) which are then moved into the debuginfo packages by find-debuginfo.sh, so the release binary is stripped.

For comparison, the file size of libQt5WebKit.so.5.6.2 drops from 34219480 to 25739056, and file now states that the binary has been stripped. The debuginfo package is generated correctly.

@llewelld llewelld marked this pull request as ready for review March 25, 2022 07:14
@llewelld
[qtwebkit] Build using -g1 flag. Fixes JB#57198
054e980 
Builds with compressed debug symobls so they can then be stripped from
the binaries and moved into the debuginfo package. Previously the build
flags blocked the stripping process.

This results in reduced binary size.
@llewelld
Copy link
Member Author

Fixed some typos in the commit message.

@llewelld llewelld merged commit 7fe4026 into sailfishos:mer-stable-on-5.6 Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainemak rainemak rainemak approved these changes

@krnlyng krnlyng Awaiting requested review from krnlyng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@llewelld @Thaodan @rainemak