New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cbindgen] Update to version 0.19.0 #7
Conversation
If you update the package the tag should be [packagename].
|
When doing packaging related changes [rpm], [spec], or [packaging] are just fine. |
But it's not packaging it is updating the package.
Packaging changes are changed that just affect packaging and not the rest of the package.
|
Continuing discussion from today's community meeting. I checked dependencies (same as this block) listed for 0.19.0 are also met in local vendor submodules. No need to touch to those submodules. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds fine, vendor submodules are good, and finally esr71 builds fine against this version. Approving.
Thanks for looking at this so carefully, for your comments and for the approval; I appreciate it. I've removed the draft status. Following @Thaodan's comments, I am more than happy to change the commit title prefix (to, say |
Sounds good to me. |
6524afd
to
48c3ebf
Compare
Done. |
No description provided.