Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cbindgen] Update to version 0.19.0 #7

Merged
merged 1 commit into from Sep 12, 2023

Conversation

llewelld
Copy link
Member

No description provided.

@Thaodan
Copy link

Thaodan commented Aug 22, 2023 via email

@rainemak
Copy link
Member

If you update the package the tag should be [packagename].

When doing packaging related changes [rpm], [spec], or [packaging] are just fine.

@Thaodan
Copy link

Thaodan commented Aug 24, 2023 via email

@rainemak
Copy link
Member

Continuing discussion from today's community meeting. I checked dependencies (same as this block) listed for 0.19.0 are also met in local vendor submodules. No need to touch to those submodules.

@rainemak rainemak self-requested a review August 31, 2023 12:01
Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine, vendor submodules are good, and finally esr71 builds fine against this version. Approving.

@llewelld llewelld marked this pull request as ready for review September 10, 2023 16:33
@llewelld
Copy link
Member Author

Thanks for looking at this so carefully, for your comments and for the approval; I appreciate it. I've removed the draft status.

Following @Thaodan's comments, I am more than happy to change the commit title prefix (to, say [cbindgen]?) if this is preferred and helps make things clearer.

@Thaodan
Copy link

Thaodan commented Sep 10, 2023

Following @Thaodan's comments, I am more than happy to change the commit title prefix (to, say [cbindgen]?) if this is preferred and helps make things clearer.

Sounds good to me.

@llewelld
Copy link
Member Author

Done.

@llewelld llewelld changed the title [packaging] Update to version 0.19.0 [cbindgen] Update to version 0.19.0 Sep 10, 2023
@mlehtima mlehtima merged commit 3bf4916 into sailfishos:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants