[rust] Add cross compilers to ix86 BuildRequires. JB#59591 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martyone
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
I would consider to say "Build-require cross compilers explicitly" instead, omitting the mention of "ix86" (because rust is built just for this arch, for the other arch we only build stubs) and stressing the fact that we required them already before but some less explicit way.
I still wonder wasn't there any reason why this obvious approach was not taken initially?
mkosola
approved these changes
Dec 16, 2022
We did use the cross compilers already before, they just weren't explicitly required here. Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.