Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check esr91 touch pipeline #1037

Closed
rainemak opened this issue Nov 13, 2023 · 2 comments
Closed

Check esr91 touch pipeline #1037

rainemak opened this issue Nov 13, 2023 · 2 comments
Assignees
Labels
esr91 Changes required to support Gecko ESR 91
Milestone

Comments

@rainemak
Copy link
Member

rainemak commented Nov 13, 2023

There are multiple things to check as many could break it.

  • First thing to check is that touch events themselves are passes correctly to the gecko embedlite from qtmozembed.
  • Check plausible build time #ifdefs / out commented code related APZC (Async Pan Controller) & APZCTreeManager related code paths (events from EmbedLiteViewParent to EmbedLiteViewChild)
  • Check plausible fatal errors in embedlite-components
  • Active status of the content

Break this task down into smaller tasks once there's visibility towards them.

@rainemak rainemak added the esr91 Changes required to support Gecko ESR 91 label Nov 13, 2023
@rainemak rainemak added this to the esr91 milestone Nov 13, 2023
@rainemak rainemak self-assigned this Nov 13, 2023
@rainemak
Copy link
Member Author

Fixed over here
llewelld/gecko-dev#4
llewelld/gecko-dev-mirror#1

Enabling APZ and then fixing incorrectly initialized TimeStamps. TimeStamp that is initialized with default constructor will have timestamp value of zero. Without real timestamp (non-zero) values mozilla::layers::Axis reports
always zero velocity. Thus, preventing mozilla::layers::AsyncPanZoomController
to handle end of panning (AsyncPanZoomController::HandleEndOfPan) so that
fling state would get triggered.

@rainemak
Copy link
Member Author

Changes integrated to the flypig's branches. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esr91 Changes required to support Gecko ESR 91
Projects
None yet
Development

No branches or pull requests

1 participant