Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] Set gfx.webrender.force-disabled to false #1015

Draft
wants to merge 9 commits into
base: next
Choose a base branch
from

Conversation

llewelld
Copy link
Member

@llewelld llewelld commented Oct 3, 2023

Sets the "gfx.webrender.force-disabled" preference to false at start up. This is to accommodate changes in Gecko ESR 91 which will automatically use the Web Render layer manager rather than the Client layer manager unless force to do otherwise using this preference. We currently need the Client layer manager for Sailfish Browser.

This is an ESR 91 change, so currently in draft to prevent it being merged.

Sets the "gfx.webrender.force-disabled" preference to false at start up.
This is to accommodate changes in Gecko ESR 91 which will automatically
use the Web Render layer manager rather than the Client layer manager
unless force to do otherwise using this preference. We currently need
the Client layer manager for Sailfish Browser.
@llewelld llewelld added this to the esr91 milestone Oct 3, 2023
@llewelld llewelld added the esr91 Changes required to support Gecko ESR 91 label Oct 3, 2023
@simonschmeisser
Copy link

Title and description say false while the diff says true

https://wiki.mozilla.org/Platform/GFX/Quantum_Render has a small hint that a different layer manager needs to be used for webrenderer

@rainemak
Copy link
Member

rainemak commented Oct 11, 2023

@llewelld pushed sailfishos-esr91 to the original as well. We can do incremental changes that are required for esr91 - pr by pr. Finally at the end create one big PR towards next. I'll create similar bracnhes for qtmozembed, gecko-dev, and embedlite-components.

llewelld and others added 8 commits December 1, 2023 23:50
Changes to gecko mean there's no use for the "confirm" parameter of the
embedui:search "loadxml" message. This change therefore removes it.
The window.setBrowserCover() call causes the browser to hang when
rendering with ESR 91. This needs to be fixed, but in the meantime
disabling the call prevents the hang from occuring.

This change prevents the browser page from being rendered on the app
cover.
When a window has the "hidden" flag set, the window will immediately be
hidden after creation. In addition, such windows are set not to appear
in the tab view and are not saved persistently. As a consequence, such
windows aren't available for interaction by the user.

This is useful for printing, which needs a window to clone the page
content into during the print. This window appears as a blank window to
the user during the print. This change allows these windows to be
hidden.
Adds DuckDuckGo to the user agent overrides.
Adds code to support the 'external' flag, which tells the gecko engine
that a request was triggered by an external application.

The flag is used to set the Sec-Fetch-* flags appropriately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esr91 Changes required to support Gecko ESR 91
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants