Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webview-docs] Elaborate on using local content with CORS protection. Fixes JB#57956 #159

Merged
merged 2 commits into from May 9, 2022

Conversation

llewelld
Copy link
Member

@llewelld llewelld commented May 5, 2022

Adds a description to the docs of three different approaches that can be used for serving local content using a WebView, in order to avoid Cross Origin Resource Sharing protection issues.

@llewelld llewelld requested a review from rainemak May 5, 2022 12:57
@llewelld
Copy link
Member Author

llewelld commented May 5, 2022

@poetaster: it'd be good to get your thoughts on this.

@poetaster
Copy link

@poetaster: it'd be good to get your thoughts on this.

If just read through it and, as usual, clear and comprehensive! This will be of utility to many frustrated devs :)

doc/index.qdoc Outdated Show resolved Hide resolved
Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment. Approving already as this looks like a good improvement / clarification.

… Fixes JB#57956

Adds a description to the docs of three different approaches that can be
used for serving local content using a WebView, in order to avoid Cross
Origin Resource Sharing protection issues.
@llewelld llewelld merged commit 9bd5b50 into sailfishos:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants