[webview] Guard programmatic preference change with marker file. Fixes JB#58269 #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llewelld
reviewed
Jun 20, 2022
…s JB#58269 Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
llewelld
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
This LGTM. I tested using layout.css.devPixelsPerPx as described in archon's original forum comment and the behaviour now works as expected. Changing it in about:config sticks between browser restarts, unless the ~/.local/share/org.sailfishos/browser/__PREFS_WRITTEN__ file is removed. Deleting __PREFS_WRITTEN__ causes the value to get reset on next restart.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Raine Makelainen raine.makelainen@jolla.com