Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow link ContextMenu options for image links. Add support for copying image URL in ContextMenu. #165

Merged
merged 4 commits into from Sep 7, 2023

Conversation

mlehtima
Copy link
Contributor

@mlehtima mlehtima commented Sep 6, 2023

No description provided.

@rainemak
Copy link
Member

rainemak commented Sep 7, 2023

Let's do some additions so that there would be also title visible when long pressing an image. At the same time we shall check that 2nd label wouldn't be the same as the title. By having title visible end user would have a bit more context for Open link in new tab, Share, Copy Link, Save link. Share would become a bit misleading as you wouldn't have context regarding what you are sharing. Is link a link or an image that you're sharing but I think we can live with that.

Further, noticed that with maximum number of items visible landscape context menu won't fit. Needs a bit of layout refactoring and flickable. @mlehtima if you don't mind, I could work a bit on the layout issues and push a commit to your branch.

Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
This commits also added ContextMenuItem that is a ListItem for
context menu use.

Signed-off-by: Raine Makelainen <raine.makelainen@jolla.com>
Copy link
Member

@rainemak rainemak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes that you did @mlehtima look good.

@mlehtima
Copy link
Contributor Author

mlehtima commented Sep 7, 2023

Changes by @rainemak look good.

@mlehtima mlehtima merged commit a212d5c into master Sep 7, 2023
@rainemak rainemak deleted the jb61064 branch September 7, 2023 14:46
@thigg
Copy link

thigg commented Sep 9, 2023

If the title is shown, finally all of xkcd can be read <3

@rainemak
Copy link
Member

If the title is shown, finally all of xkcd can be read <3

Created a small PR sailfishos/embedlite-components#95

Especially xkcd titles are very long. Thus, we should either calculate font size or just reduce font size. However, that's another PR.

@rainemak
Copy link
Member

Max 4 lines and smaller font: #166

Screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants