Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync with upstream #2

Merged
merged 7 commits into from Nov 29, 2022
Merged

sync with upstream #2

merged 7 commits into from Nov 29, 2022

Conversation

vigejolla
Copy link
Member

No description provided.

monich
monich approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@monich monich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if no changes are being introduced, it's ok to just fast-forward, without introducing an additional merge commit. Otherwise, LGTM.

@vigejolla
Copy link
Member Author

I think if no changes are being introduced, it's ok to just fast-forward, without introducing an additional merge commit.

That was my plan all along. I could have mentioned that, sorry.

@vigejolla vigejolla merged commit c3661ee into master Nov 29, 2022
@vigejolla vigejolla deleted the jb59355-2 branch November 29, 2022 05:11
@monich
Copy link
Member

monich commented Nov 29, 2022

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monich monich monich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vigejolla @monich