Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sailfish-qdoc-template] Add left margin. JB#57817 #4

Merged
merged 1 commit into from Jan 26, 2023
Merged

Conversation

vigejolla
Copy link
Member

No description provided.

@martyone
Copy link
Member

How does it look with the viewers where the border was not missing? Please remind be whether we use other viewers nowadays :)

@vigejolla
Copy link
Member Author

How does it look with the viewers where the border was not missing? Please remind be whether we use other viewers nowadays :)

SDK 3.7.4:

sdk-374

SDK 3.10.1 without the added margin:

without_margin

SDK 3.10.1 with the added margin:

with_margin

@vigejolla
Copy link
Member Author

To my knowledge we don't use any other viewers

@martyone
Copy link
Member

hm, wouldn't it be more future-proof to add the margin to the widget instead? That is closer to where the issue actually exists anyway, isn't it?

@vigejolla
Copy link
Member Author

hm, wouldn't it be more future-proof to add the margin to the widget instead? That is closer to where the issue actually exists anyway, isn't it?

In my opinion it makes more sense to try to follow what Qt has done with their docs. Of course, this is just a small part of that, there's still plenty to do if want to get our docs as good looking. But this task was just about the margin, and it's done here.

@vigejolla
Copy link
Member Author

In my opinion it makes more sense to try to follow what Qt has done with their docs.

Of course I did a lousy job at that. I now realize I should have just changed the "margin-left" in body from 0.5em to 5px. That's what they did. I somehow wasn't paying enough attention.

@martyone
Copy link
Member

If the margin is added in upstream, then there is no question about :)

@vigejolla
Copy link
Member Author

If the margin is added in upstream, then there is no question about :)

It is, but like I wrote above, I added it wrong. I'll update the PR shortly.

Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
@vigejolla vigejolla merged commit e5b89fa into master Jan 26, 2023
@vigejolla vigejolla deleted the jb57817 branch January 26, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants