New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sailfish-qdoc-template] Add left margin. JB#57817 #4
Conversation
|
How does it look with the viewers where the border was not missing? Please remind be whether we use other viewers nowadays :) |
|
To my knowledge we don't use any other viewers |
|
hm, wouldn't it be more future-proof to add the margin to the widget instead? That is closer to where the issue actually exists anyway, isn't it? |
In my opinion it makes more sense to try to follow what Qt has done with their docs. Of course, this is just a small part of that, there's still plenty to do if want to get our docs as good looking. But this task was just about the margin, and it's done here. |
Of course I did a lousy job at that. I now realize I should have just changed the "margin-left" in body from 0.5em to 5px. That's what they did. I somehow wasn't paying enough attention. |
|
If the margin is added in upstream, then there is no question about :) |
It is, but like I wrote above, I added it wrong. I'll update the PR shortly. |
Signed-off-by: Ville Nummela <ville.nummela@jolla.com>



No description provided.