Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Valgrind: Allow memcheck with tunneled connections #533

Merged
merged 1 commit into from Dec 20, 2022
Merged

Valgrind: Allow memcheck with tunneled connections #533

merged 1 commit into from Dec 20, 2022

Conversation

martyone
Copy link
Member

@martyone martyone commented Aug 4, 2022

No description provided.

@martyone martyone requested a review from rainemak August 4, 2022 09:15
@martyone martyone requested review from vigejolla and removed request for vigejolla December 20, 2022 07:12
vigejolla
vigejolla approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@vigejolla vigejolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Took me longer than it should have taken to wrap my head around this one. Should have started by reading the comment starting from line 379 first...

@martyone
Copy link
Member Author

Rebased

@martyone martyone merged commit b96895d into master Dec 20, 2022
@martyone martyone deleted the jb58414 branch December 20, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigejolla vigejolla vigejolla approved these changes

@rainemak rainemak Awaiting requested review from rainemak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martyone @vigejolla