Sfdk: Allow optional access to host devices. JB#59670 #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main motivation here is to get access to dynamically created loop and LVM devices, which are needed for device image creation. It still needs the '--privileged' option to actually allow accessing these devices (controlled by the SAILFISH_SDK_DOCKER_RUN_PRIVILEGED env var). Or from the other side: with the defauts it is hardly possible to screw something up on the host through the bind-mounted /dev.
vigejolla
approved these changes
Jan 12, 2023
|
Nice tip. Strange I never hit a reference on this option while looking for possible solutions. There is also a need to use LVM, which would need something more flexible for proper filtering - haven't checked yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.