Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sailfish-secrets] Create the socket directory in the plugin also. Contributes to JB#56300 #183

Merged
merged 1 commit into from Dec 24, 2021

Conversation

dcaliste
Copy link
Contributor

Plugin are initialised before the daemon is creating its own
socket and ensuring the exitence of the directory under
/run/user/xxx/sailfishsecretsd. So create also that directory
in the password agent plugin which is using this directory.

@chriadam : this is the true root of the problem, I guess. By moving the socket under a subdirectory, I created an issue with this plugin that was then unable to start its QDBusServer because the path was not existing yet (it's created later on by the daemon). It also explains why when testing it was always working : because then the directory was existing and everything was working after a daemon restart. While it was not working directly after a boot of the device.

Plugin are initialised before the daemon is creating its own
socket and ensuring the exitence of the directory under
/run/user/xxx/sailfishsecretsd. So create also that directory
in the password agent plugin which is using this directory.
@chriadam
Copy link
Contributor

Ah, interesting... is it not possible to force the daemon to create the appropriate sockets and socket directory, before initialising the plugins?

@chriadam
Copy link
Contributor

But I guess this is correct too, since this plugin is using that directory. LGTM.

@chriadam
Copy link
Contributor

I will ask Jorma if this can sneak into the 4.4.0 release...

@dcaliste
Copy link
Contributor Author

But I guess this is correct too, since this plugin is using that directory.

Yes, I prefer to create the directory where it is used, than assumed that it will be created at the right time by the daemon.

@chriadam chriadam changed the title [sailfish-secrets] Create the socket directory in the plugin also. [sailfish-secrets] Create the socket directory in the plugin also. Contributes to JB#56300 Dec 24, 2021
@chriadam
Copy link
Contributor

LGTM, tyvm.

@chriadam chriadam merged commit a9e54b3 into sailfishos:master Dec 24, 2021
@dcaliste
Copy link
Contributor Author

Great, thank you and merry Christmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants