New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sailfish-utilities] Add a Restart Bluetooth button. JB#58019 #54
Conversation
876dbf8
to
6af7c4b
Compare
|
Hm, I'd be a little cautious on adding new options to the utilities. As was coming up in the forum discussion, ideally we'd fix the underlying bugs so the utilities wouldn't be needed. Maybe even some day getting rid of the whole thing. Then again if there are adaptation side bugs related it could warrant for adding this. @jusa what's your view? |
|
I'm not Jusa but some options help when the underlying vendor-software/hardware is buggy. |
82a9ee8
to
b9349c1
Compare
Agreed that ideally this whole package needn't exist at all. While it does though, and while users are still reporting problems about two releases later, and are reporting that something like this thing here helps in practice, is there any interest in this PR? |
0d299db
to
7e78281
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes out and they worked nicely. I've made a few minor suggestions.
From reading the forums, I'm not sure whether this is still an issue for users. If it is, then I think we should consider accepting this PR. @nephors, are you still seeing reports of bluetooth problems that restarting the Bluetooth stack seems to fix?
Is this still a work-in-progress?
I have not seen any reports of it in recent times. Myself I use and need this from time to time on SFOS4.2/Xperia10-one as BT devices sometimes just won't connect.
It is in the sense I am ready to make any changes required. However I do not have a great amount of devices and SFOS Versions to test on, and there are differences in the actions required to make the restart work depending on at least OS version, maybe even device. |
|
Once I have guidance on the two points:
I can rebase, squash and update this branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Concerning the ordering, I personally would prefer to see items added at the end, to avoid messing with users' muscle memory.
The alphabetic ordering and categorisation is a bit nebulous anyway, since in the UI they're translated differently (e.g. "Network Restart", "Home screen Restart" aren't alphabetical).
I could see an argument for keeping the Restart and Clear items together. In that case, please rebase onto the latest changes and fix the ordering of the Fingerprint Restart button too.
This adds a new option in the Utilities Menu to restart Bluetooth related services Co-authored-by: David Llewellyn-Jones <david@flypig.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for a nice addition @nephros, and for making the changes. This looks good to me now.
This adds a new option in the Utilities Menu to restart the Bluetooth related services, dealing with this feature request
Please review and comment:
Resolves: #61