Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sailfish-utilities] Add a Restart Fingerprint button. Fixes JB#57941 #62

Merged
merged 2 commits into from Apr 23, 2022

Conversation

llewelld
Copy link
Member

Adds a button for restarting the fingerprint service. In practice, it
restarts, waits 10 seconds and then restarts again.

In some situations where the fingerprint cache gets messed up, which
prevents fingerprints from being recognised, this sequence resolves the
issue.

Adds various files (*.cpp, *.h, *.sh) to the project file so they appear
in the Sailfish IDE.

CMake is used for the actual building, so this doesn't affect the build
process.
@llewelld
Copy link
Member Author

@nephros, please feel free to add your review too.

@llewelld llewelld requested a review from pvuorela April 21, 2022 13:38
@llewelld
Copy link
Member Author

See the related forum thread for background: https://forum.sailfishos.org/t/fingerprint-record-lost-randomly/6283/81

@abranson
Copy link
Member

Does it need a whole ten seconds? That'll seem like a long time with a spinner.

@llewelld
Copy link
Member Author

Does it need a whole ten seconds? That'll seem like a long time with a spinner.

Yes, it is a long time to wait, you're right. I basically took this from the reports on the forum which all seem to use either 10 or 20 seconds as the gap. But it would be better if it could be less.

We could go with something short and increase the length if it turns out to be unreliable. Would you have a suggestion as a starting point?

@abranson
Copy link
Member

I think I usually only wait for 2 or 3, so 5 might be enough

@attah
Copy link

attah commented Apr 22, 2022

I too think 10 is excessive. I run the restart commands basically as fast as i can type my password.

@llewelld
Copy link
Member Author

Thanks for the feedback both. I've set it to 5 seconds. It still feels like quite a long time, so maybe it could go lower?

@abranson
Copy link
Member

Maybe two or three? You can always press it again if it wasn't long enough.

@llewelld
Copy link
Member Author

I've set it to three. If it proves ineffective, we can bump it up later (it's pretty easy to change on-device as well).

Adds a button for restarting the fingerprint service. In practice, it
restarts, waits 3 seconds and then restarts again.

In some situations where the fingerprint cache gets messed up, which
prevents fingerprints from being recognised, this sequence resolves the
issue.
@llewelld
Copy link
Member Author

Updated commit message s/10/3/g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants