New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sailfish-utilities] Use DSO as target for more info links. JB#59782 #63
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new links are much nicer: relevant and more professional looking too, so these changes make perfect sense.
It's just a thought but I wonder if it would make sense to pass the links to the qsTrId as a parameter, to avoid having to redo all translations if the location changes in future.
Either way, this looks good to me.
|
It certainly makes sense to externalise HTML tags and URL, not only to reduce burden per-language, but also to prevent any little Bobby Tables cases:) Here's an example of "extra comment" of how I'd suggest to implement this: https://translate.sailfishos.org/en_GB/jolla-settings-system/translate/settings-system.ts#unit=437942 While our extra comment would read: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks vigejolla. Although you didn't quite follow sledges suggested wording, I personally think the wording you've used is just fine.
Just one small change needed in order to make the tracker link work, but otherwise this looks good to me.
…. JB#59782 Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
|
Changed also the text ID to prevent pootle from wiping out old translations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙇
|
P. S.: Should one commit have "Fixes" for the bug? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me and works nicely. The updated links are definitely a nice improvement.
…59782 TJC is in read only mode, in DSO we can update the docs. Signed-off-by: Ville Nummela <ville.nummela@jolla.com>
Yes. I believe you can guess my reasoning behind the decision to leave it out, and also now adding it after you pointed it out 😄 |
TJC is in read only mode, in DSO we can update the docs.