[sailfish-utilities] Add restart keyboard action. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's perfectly fine that community contribution is without JB#. The one who integrates shall take care of changelog generation. |
rainemak
reviewed
Sep 5, 2023
rainemak
reviewed
Sep 5, 2023
Multi-line engineering English descriptions are automatically concatenated. Co-authored-by: Raine Mäkeläinen <raine.makelainen@jolla.com>
|
I fixed it, thanks for reviewing! |
rainemak
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #52 but I didn't mention it in the commit message because other commits refer to "JB" numbers while the contributing guidelines appear outdated.
The "restart keyboard" action was removed in ac4d84c in 2016. My implementation uses a direct DBus call instead of going through the C++ side plus Bash.
(I created a patch for Patchmanager as well.)