[permissions] Remove PDF tools #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off; many thanks for adding this originally.
I really had no idea if i could change over in time for 4.4.
But SeaPrint 1.0 seems to have been a success, so now these are not needed anymore.
I have something like one-and-a-half report that something stopped working compared to 0.9, but they never followed up... so should be fine.
For discussion: could be sensible waiting another minor-version of SFOS before merging.
For discussion 2: I would be open to (try to) contribute to share-as-pdf for Sailfish-Office so Calligraconverter can be dropped, but afaict there is no "neutral ground" to hand over such files. Feel free to poke me in IRC or the forums as well.