Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[permissions] Add Sharing permission details to the README. Fixes JB#58483 #129

Merged
merged 1 commit into from Jan 10, 2023

Conversation

llewelld
Copy link
Member

@llewelld llewelld commented Aug 9, 2022

Adds some info about the Sharing permission for accessing the Share API,
specifically to clarify that it is available to all applications by
default.

@Thaodan
Copy link

Thaodan commented Aug 9, 2022

Can you mention the version when to are available? Like for example: "Available since version x.x"?

@llewelld
Copy link
Member Author

llewelld commented Aug 9, 2022

Can you mention the version when to are available? Like for example: "Available since version x.x"?

The Share API and Sharing permission were both released in 4.2.0 (after the sandboxing was made available in 4.0.1). Given this, I'm thinking this kind of info might be more appropriate in the Share API documentation itself rather than here. What do you think?

@Thaodan
Copy link

Thaodan commented Aug 9, 2022

Can you mention the version when to are available? Like for example: "Available since version x.x"?

The Share API and Sharing permission were both released in 4.2.0 (after the sandboxing was made available in 4.0.1). Given this, I'm thinking this kind of info might be more appropriate in the Share API documentation itself rather than here. What do you think?

Hm it might make sense to have it in both since it is quite useful to have it in this list too, I was thinking of another column that says so for each permission.

@Olf0
Copy link
Contributor

Olf0 commented Aug 9, 2022

Hm it might make sense to have it in both since it is quite useful to have it in this list too, I was thinking of another column that says so for each permission.

Two separate places to maintain the same information is usually not a good idea, because they have to be concurrently updated.
Usually links are a much better solution, because they alleviate the issue of "updated info here, but missed to update its copy somewhere else".

Copy link
Contributor

@Olf0 Olf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The created description text is fine IMO.

@rainemak
Copy link
Member

@llewelld could you rebase and merge?

…58483

Adds some info about the Sharing permission for accessing the Share API,
specifically to clarify that it is available to all applications by
default.
@llewelld
Copy link
Member Author

llewelld commented Jan 10, 2023

Rebased. Sorry for the delay in getting this merged; I lost track of it.

@llewelld llewelld merged commit 4e34f1e into master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants